People can post YouTube videos now. How'd I overlook that old bit of lulzbb functionality?
Edit: It seems to be ignoring the height I set for the embed... I may have to inspect some code. The height is 236px instead of the 315px default, straight from YouTube's own embed markup.
Edit 2: ugh I just remembered that means I have to deal with FTP
I miss SSH so much.
Edit 3: Pwnt. The code was actually hard-limiting the aspect ratio of the player. It now fully respects the settings in the admin panel.
Edit 4: In fact, let's force it to always be the dimensions set in the admin panel. This overrides the mod's functionality of allowing the person posting to set the width and height in the bbcode tag. I see no downsides to this since the embed contains both a "View on YouTube" button and a "Fullscreen" button. We got along just fine on lulzbb with a sensibly small YouTube embed, I see no reason why we can't get along with a similarly sensibly small one now.
Edit 5: I really need to get a local dev environment set up so I can test code tweaks much more easily, and make mods to fix issues in the forums much more easily, and then I can just use FTP or the package manager in the admin panel to push changes. Something similar to a full copydown
process, but only ever doing copydown when I hit a button as opposed to daily.
Edit 6: Properly disabled setting the width and height by preventing the parameters from being parsed. Good day, sir.
Edit 7 (2016-03-31): y u edit mai post thatcher